Increase timeout before gtm init to 3 seconds for yt video api compat #280
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirtds
approved these changes
Jul 11, 2023
bryanlandia
deleted the
bugfix/gtm-with-video-measurement-breaks-video-load
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Cockroach still saw on and off problems with YouTube video loading because of an issue with GTM initialization even after introducing a 1 second timeout. Trying to increase timeout to 3 secs.
Type of change
Related issues
https://appsembler.atlassian.net/browse/ENG-97
Checklists
Development
Security
Code review